C# help using a variable from one class/script file in another

[Astaldoath]

Basically what im trying to do is use public static string curClass; as a variable to hold the players class when a button is pushed. Then in the next script file, im using it in a switch to alter the amount of hit points the player gets per point of constitution.

I dont get errors but when you put points in vitality ect.. the Health, Stamina, mana doesnt update. It did update fine before i added the switch. I seems like it should work from what i know of programming.

Any help is appreciated

private void SetupVitalModifiers() {
		
		switch (CharacterGenerator.curClass) {
		
			case "Warrior":	//Warrior
				//Health
				GetVital((int)VitalName.Health).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Constitution), 2));
				//Stamina
				GetVital((int)VitalName.Stamina).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Constitution), 1));
				//Mana
				GetVital((int)VitalName.Mana).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Wisdom), .5f)); 
				break;
			
		case "Archer":
				//Health
				GetVital((int)VitalName.Health).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Constitution), 1));
				//Stamina
				GetVital((int)VitalName.Stamina).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Constitution), 2));
				//Mana
				GetVital((int)VitalName.Mana).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Wisdom), .5f)); 
				break;

		case " Rogue":
				//Health
				GetVital((int)VitalName.Health).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Constitution), 1));
				//Stamina
				GetVital((int)VitalName.Stamina).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Constitution), 2));
				//Mana
				GetVital((int)VitalName.Mana).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Wisdom), .5f)); 
				break;
			
			case "Wizard":
				//Health
				GetVital((int)VitalName.Health).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Constitution), 1));
				//Stamina
				GetVital((int)VitalName.Stamina).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Constitution), .5f));
				//Mana
				GetVital((int)VitalName.Mana).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Wisdom), 2)); 
				break;
			
			case " Priest":
				//Health
				GetVital((int)VitalName.Health).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Constitution), 1));
				//Stamina
				GetVital((int)VitalName.Stamina).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Constitution), .5f));
				//Mana
				GetVital((int)VitalName.Mana).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Wisdom), 2)); 
				break;
		}
	}

using UnityEngine;
using System.Collections;
using System;
using System.Collections.Generic;

public class CharacterGenerator : MonoBehaviour {
	private PlayerCharacter _toon;
	private const int STARTING_POINTS = 350;
	private const int MINSTARTING_ATTRIBUTE_VALUE = 10;
	private const int STARTING_VALUE = 50;
	private int pointsLeft;
	public static string curClass;
		
	// Use this for initialization
	void Start () {
		_toon = new PlayerCharacter();
		_toon.Awake ();
		
		pointsLeft = STARTING_POINTS;	
		curClass = "  None";
		
		for(int cnt = 0; cnt < Enum.GetValues(typeof(AttributeName)).Length; cnt++) {
			_toon.GetPrimaryAttribute(cnt).BaseValue = STARTING_VALUE;
			pointsLeft -=(STARTING_VALUE - MINSTARTING_ATTRIBUTE_VALUE);
		}
		_toon.StatUpdate();
	}
	
	// Update is called once per frame
	void Update () {

	}
	
	void OnGUI() {
		DisplayName();
		DisplayPoints();
		DisplayAttributes();	
		DisplayVitals();
		DisplaySkills();
		DisplayClass();
	}
	
	
	private void DisplayName() {
		GUI.Label(new Rect(10, 10, 50, 25), "Name:");
		_toon.Name = GUI.TextField(new Rect(65, 10, 200, 25), _toon.Name);
	}
	
	private void DisplayAttributes() {
		for(int cnt = 0; cnt < Enum.GetValues(typeof(AttributeName)).Length; cnt++) {
			GUI.Label(new Rect(10, 40 +(cnt * 25), 100, 25),((AttributeName)cnt).ToString() );
			GUI.Label(new Rect(115, 40 +(cnt * 25), 30, 25), _toon.GetPrimaryAttribute(cnt).AdjustedBaseValue.ToString());			
			if(GUI.Button(new Rect(150,40 +(cnt * 25), 25, 25), "-")) {
				if(_toon.GetPrimaryAttribute(cnt).BaseValue > MINSTARTING_ATTRIBUTE_VALUE) {
					_toon.GetPrimaryAttribute(cnt).BaseValue--;
					pointsLeft++;
					_toon.StatUpdate();
				}
			}
			if(GUI.Button(new Rect(180,40 +(cnt * 25), 25, 25), "+")) {
				if(pointsLeft > 0) {
					_toon.GetPrimaryAttribute(cnt).BaseValue++;
					pointsLeft--;
					_toon.StatUpdate();
				}
			}
		}
	}
	
	private void DisplayVitals() {
		for(int cnt = 0; cnt < Enum.GetValues(typeof(VitalName)).Length; cnt++) {
			GUI.Label(new Rect(10, 40 + ((cnt + 7) * 25), 100, 25),((VitalName)cnt).ToString());
			GUI.Label(new Rect(115, 40 + ((cnt + 7) * 25), 30, 25), _toon.GetVital(cnt).AdjustedBaseValue.ToString());			
		}
	}
	
	private void DisplaySkills() {
		for(int cnt = 0; cnt < Enum.GetValues(typeof(SkillName)).Length; cnt++) {
			GUI.Label(new Rect(300, 40 + (cnt * 25), 100, 25),((SkillName)cnt).ToString());
			GUI.Label(new Rect(405, 40 + (cnt * 25), 30, 25), _toon.GetSkill(cnt).AdjustedBaseValue.ToString());			
		}
	}
	
	private void DisplayPoints() {
		GUI.Label(new Rect(300, 13, 200, 25), "Points Available: " + pointsLeft.ToString());	
	}
	

	
	//private void DisplayClass () {
		//for(int cnt = 0; cnt < Enum.GetValues(typeof(CharacterClassName)).Length; cnt++) {
		//GUI.Button(new Rect(500, 40 + (cnt * 28), 150, 25),((CharacterClassName)cnt).ToString());
		//}
		//GUI.Label(new Rect(500, 12, 60, 25), "Class: "); //left,top,width,height	
	//}
	
	private void DisplayClass () {
		
		if(GUI.Button(new Rect(500, 40 + 28, 150, 25),"Warrior")) {
			curClass = "Warrior";
		}

		if(GUI.Button(new Rect(500, 65 + 28, 150, 25),"Archer")) {
			curClass = "Archer";
		}
		
		if(GUI.Button(new Rect(500, 90 + 28, 150, 25),"Rogue")) {
			curClass = " Rogue";
		}
		
		if(GUI.Button(new Rect(500, 115 + 28, 150, 25),"Wizard")) {
			curClass = "Wizard";
		}
		
		if(GUI.Button(new Rect(500, 140 + 28, 150, 25),"Priest")) {
			curClass = " Priest";
		}
		
		GUI.TextField(new Rect(555, 12, 40, 25), "Class"); //left,top,width,height
		GUI.TextField(new Rect(550, 40, 50, 25), curClass);
	}

}

[karnautrahl]

Care to zip the source up bud?

I know what unity is, though not used it myself it. Just interested to see if I can debug it for you.

I can't see anything just reading it myself, so I'll chuck it into vs for you and look at it properly. Assuming you didn't fix it already.

[sysigy]

First off I noticed spaces in some of your case lines between the ""... eg, " Rogue", this will fail because of the additional space...
" Rogue" does not equal "Rogue".

Over the years I've seen .net sometimes have issues comparing strings so I would change your 'player current class' variable from a string to an enum...

public enum PlayerClass : byte
{
    [Description("Warrior")]
    Warrior = 1,
    [Description("Archer")]
    Archer = 2,
    [Description("Rogue")]
    Rogue = 3,
    [Description("Wizard")]
    Wizard = 4,
    [Description("Priest")]
    Priest = 5
}

// change CharacterGenerator.curClass type to 'PlayerClass'
public static PlayerClass curClass { get; set; }

This will give you a benefit of making CharacterGenerator.curClass 'strongly typed' and help reduce the likeliness of syntax errors and typo's when dealing with strings.

Then alter your switch statement:

switch (CharacterGenerator.curClass)
{
    case PlayerClass.Warrior:
        break;
    case PlayerClass.Archer:
        break;
    case PlayerClass.Wizard:
        break;
    case PlayerClass.Rogue:
        break;
    case PlayerClass.Priest:
        break;
}

Try that and see if it fixes your problem.

Additional Comment:

IMO - I think storing the current class of the player in a global static variable in your 'CharacterGenerator' object isn't a good practice. I would store the current class of the player in your 'PlayerCharacter' object instead so it can be referenced 'playerCharacter.curClass' for example.

Additional Comment:

Just thought of something else...

If you were using 'curClass' as a string so you can output it to the HUD you can still do as such using the new 'PlayerClass' enum by a couple of methods... easiest way is to use:

CharacterGenerator.curClass.ToString();

BUT, if you wanted a new class that had a space in the name, for example: "Super Warrior" enums don't allow spaces so the enum element would be 'SuperWarrior = 6' and then attaching the '[Description("Super Warrior")]' to it for the screen friendly text would solve your problem.... almost!

The next thing is, "How do I show the description of an enum element?" well, I personally like using an 'extension method':

Create an 'Extensions' class somewhere in your project:

public static class Extensions
{
    public static string ToDescription(this Enum en)
    {
         Type type = en.GetType();
         MemberInfo[] memberInfo = type.GetMember(en.ToString());
         if (memberInfo != null && memberInfo.Length > 0)
         {
             object attributes = memberInfo[0].GetCustomAttributes(typeof(DescriptionAttribute), false);

             if (attributes != null && attributes.Length > 0)
                return (attributes[0] as DescriptionAttribute).Description;
         }
         
         return en.ToString();
    }
}

Then all you have to do is reference this namespace at the top of your code file e.g. 'using MyGame.Extensions;' with the other 'using' blocks and then you can do the following:

CharacterGenerator.curClass.ToDescription();

[CodeWeasel]

Awesome post.

Remember: Unnecessary global variables in a strongly-typed OO language make Bjarne Stroustrup cry.